Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions raised at __crystal_sigfault_handler #8743

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

waj
Copy link
Member

@waj waj commented Feb 4, 2020

Similar to #8735 but for exceptions being raised within the function that capture fault signals.

Sometimes the memory is corrupted before the SEGV signal and this function fails while checking for a stack overflow. An exception is raised and the tipical END_OF_STACK message is displayed instead.

@waj waj added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:system labels Feb 4, 2020
@waj waj added this to the 0.33.0 milestone Feb 5, 2020
@waj waj merged commit 37d6047 into crystal-lang:master Feb 5, 2020
@waj waj deleted the fix/sigfault-exception-handler branch February 5, 2020 19:33
@RX14
Copy link
Contributor

RX14 commented Feb 7, 2020

What fails? Fiber.current?

I'm surprised you get an exception instead of a segfault if there's corruption?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants